Addon Test: Add Vitest 3 support #30181
Conversation
valentinpalkovic
changed the base branch from
next
to
valentin/a11y-refactorings
|
Failed to publish canary version of this pull request, triggered by @valentinpalkovic. See the failed workflow run at: /~https://github.com/storybookjs/storybook/actions/runs/12596687166 |
… valentin/add-vitest-3-support
|
Failed to publish canary version of this pull request, triggered by @valentinpalkovic. See the failed workflow run at: /~https://github.com/storybookjs/storybook/actions/runs/12596812168 |
|
View your CI Pipeline Execution ↗ for commit f4373a5.
☁️ Nx Cloud last updated this comment at |
|
Failed to publish canary version of this pull request, triggered by @valentinpalkovic. See the failed workflow run at: /~https://github.com/storybookjs/storybook/actions/runs/12596958152 |
valentinpalkovic
added
bug
ci:daily
… valentin/add-vitest-3-support
… valentin/add-vitest-3-support
… valentin/add-vitest-3-support
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 60 | 60 | 0 |
| Self size | 762 KB | 832 KB | 🚨 +70 KB 🚨 |
| Dependency size | 14.15 MB | 14.15 MB | 🚨 +18 B 🚨 |
| Bundle Size Analyzer | Link | Link |
| @@ -96,7 +96,7 @@ describe('eslint-plugin fix', () => { | |||
| }); | |||
|
|
|||
| describe('should install eslint plugin', () => { | |||
| it('when .eslintrc is using a supported extension', async () => { | |||
| it.skip('when .eslintrc is using a supported extension', async () => { | |||
There was a problem hiding this comment.
I may need some help from @yannbf figuring out why, in Vitest 3, these tests are failing.
valentinpalkovic
added
ci:normal
and removed
ci:daily
valentinpalkovic
requested review from
kylegach and
jonniebigodes
as code owners
|
Currently blocked by vitest-dev/vitest#7212 |
test-storybooks/portable-stories-kitchen-sink/react/.storybook/main.ts
Outdated
Show resolved
Hide resolved
Closes #
What I did
@storybook/experimental-addon-testto support Vitest 3Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30181-sha-2fdb0bfe. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-30181-sha-2fdb0bfe sandboxor in an existing project withnpx storybook@0.0.0-pr-30181-sha-2fdb0bfe upgrade.More information
0.0.0-pr-30181-sha-2fdb0bfevalentin/add-vitest-3-support2fdb0bfe1736930437)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30181