Replaced deprecated cmd to fix package uninstall #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightwalker-87
approved these changes
Oct 3, 2024
Nightwalker-87
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the “cmake_uninstall.cmake.in” in the test branch can't remove any installation files, but still prompted files uninstalled. Then I located a bug at this line:
COMMAND "@CMAKE_COMMAND@" -E remove \"{file}\", and found that there are two issues: 1st. the "" was added in front of the file string quote, resulting in incorrect parsing of the file path, it needs to be removed. 2nd. The deprecatedcmake -E removecommand does not check whether the file path is correct, nor return an error to be captured by if(NOT "${rm_retval}" STREQUAL 0), the solution is to use 'cmake -E rm' instead. I have made these fix and added a file verification to my fork repository, I hope to contribute my code here.