-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactoring] sourcefile 'common.c' #1218
[refactoring] sourcefile 'common.c' #1218
Conversation
File divided to some parts. Functions with "flash" in names extracted to common_flash.c, with "option" extracted to option.c etc. Removed unnecessary headers. Removed one single function which was used nowhere. And so on. Project built under Windows and seems to be working.
File divided to some parts. Functions with "flash" in names extracted to common_flash.c, with "option" extracted to option.c etc. Removed unnecessary headers. Removed one single function which was used nowhere. And so on. Project built under Windows and seems to be working.
Problem with some defines... going to fix tomorrow or so. |
@hydroconstructor Please note that there is a PR #1216 already open, so please ensure that
|
Added forgotten defines
In #1212 pointed: rewrite and modularisation of: chipid.c chipid.h common.c stlink.h stm32.h Here, I tried to rewrite and modularise common.c - splitting it to some files. Or maybe split common.c in different branch, not chipid_cleanup - and merge them later? |
As long as it does not conflict with HEAD in branch |
598f34d
to
e2dcf07
Compare
File divided to some parts. Functions with "flash" in names extracted to common_flash.c, with "option" extracted to option.c etc.
Removed unnecessary headers.
Removed one single function which was used nowhere.
And so on.
Project built under Windows and Ubuntu and seems to be working.