-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Closes #332) add support for newunit in F2008 OPEN() #369
Conversation
Codecov ReportBase: 91.54% // Head: 91.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 91.54% 91.55%
=======================================
Files 37 37
Lines 13224 13263 +39
=======================================
+ Hits 12106 12143 +37
- Misses 1118 1120 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Ready for first review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arporter See a few comments regarding pylint issues and bring it to master, there is currently a merge conflict.
Ready for another look now from @sergisiso . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arporter All comments have been addressed. This is approved for merging.
* master: (167 commits) stfc#380 Update changelog stfc#369 Update changelog and remove repeated import stfc#380 fix Black error stfc#380 enhance tests stfc#380 fix black formatting errors stfc#369 fix/disable various pylint issues stfc#369 fix duplicated imports after merge stfc#381 Update changelog stfc#381 really, really fix missing coverage stfc#381 fix remaining test stfc#298 add (failing) test for no match stfc#381 revert property to method to support older Python versions stfc#298 ensure F2008 flavour of Alloc_Opt_List used in match stfc#380 fix bug and extend and tidy tests stfc#380 move existing rename test to new file and add further tests #739 ensure symbol table cleanly ignores operators and add tests pr stfc#376. Updated changelog ready for merge to master. stfc#376 fix list ordering issue in test stfc#376 rename internal members to avoid confusion stfc#376 tidying for review ...
No description provided.