Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #332) add support for newunit in F2008 OPEN() #369

Merged
merged 12 commits into from
Oct 18, 2022

Conversation

arporter
Copy link
Member

@arporter arporter commented Aug 9, 2022

No description provided.

@arporter arporter self-assigned this Aug 9, 2022
@arporter arporter marked this pull request as draft August 9, 2022 20:47
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Base: 91.54% // Head: 91.55% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d631c38) compared to base (e3c0ad8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   91.54%   91.55%           
=======================================
  Files          37       37           
  Lines       13224    13263   +39     
=======================================
+ Hits        12106    12143   +37     
- Misses       1118     1120    +2     
Impacted Files Coverage Δ
src/fparser/two/Fortran2008.py 99.30% <100.00%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arporter arporter marked this pull request as ready for review September 2, 2022 09:51
@arporter
Copy link
Member Author

arporter commented Sep 2, 2022

Ready for first review now.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter See a few comments regarding pylint issues and bring it to master, there is currently a merge conflict.

@sergisiso sergisiso added reviewed with actions PR has been reviewed and is back with developer and removed under review labels Oct 13, 2022
@arporter
Copy link
Member Author

Ready for another look now from @sergisiso .

@arporter arporter added ready for review and removed reviewed with actions PR has been reviewed and is back with developer in progress labels Oct 18, 2022
Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter All comments have been addressed. This is approved for merging.

@sergisiso sergisiso added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels Oct 18, 2022
@sergisiso sergisiso merged commit 547a138 into master Oct 18, 2022
@sergisiso sergisiso deleted the 332_open_newunit branch October 18, 2022 10:21
ZedThree added a commit to PlasmaFAIR/fparser that referenced this pull request Oct 18, 2022
* master: (167 commits)
  stfc#380 Update changelog
  stfc#369 Update changelog and remove repeated import
  stfc#380 fix Black error
  stfc#380 enhance tests
  stfc#380 fix black formatting errors
  stfc#369 fix/disable various pylint issues
  stfc#369 fix duplicated imports after merge
  stfc#381 Update changelog
  stfc#381 really, really fix missing coverage
  stfc#381 fix remaining test
  stfc#298 add (failing) test for no match
  stfc#381 revert property to method to support older Python versions
  stfc#298 ensure F2008 flavour of Alloc_Opt_List used in match
  stfc#380 fix bug and extend and tidy tests
  stfc#380 move existing rename test to new file and add further tests
  #739 ensure symbol table cleanly ignores operators and add tests
  pr stfc#376. Updated changelog ready for merge to master.
  stfc#376 fix list ordering issue in test
  stfc#376 rename internal members to avoid confusion
  stfc#376 tidying for review
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready for merge PR is waiting on final CI checks before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants