Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#304 add pip_requirements file and doc target in setup.py #305

Merged
merged 2 commits into from
Dec 2, 2021
Merged

#304 add pip_requirements file and doc target in setup.py #305

merged 2 commits into from
Dec 2, 2021

Conversation

arporter
Copy link
Member

@arporter arporter commented Nov 4, 2021

No description provided.

@arporter arporter self-assigned this Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #305 (0b9d77c) into master (ee5c0e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files          35       35           
  Lines       12917    12917           
=======================================
  Hits        11749    11749           
  Misses       1168     1168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5c0e8...0b9d77c. Read the comment docs.

@arporter
Copy link
Member Author

arporter commented Nov 4, 2021

Very small change that just kicks the RTD build into shape. One for either @rupertford or @sergisiso.

rupertford
rupertford approved these changes Dec 2, 2021
View reviewed changes
Copy link
Collaborator

@rupertford rupertford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Approving.

@rupertford rupertford added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels Dec 2, 2021
@rupertford rupertford merged commit 6558244 into master Dec 2, 2021
@rupertford rupertford deleted the 304_rtd_build_fix branch December 2, 2021 13:26
@rupertford rupertford mentioned this pull request Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupertford rupertford rupertford approved these changes

@sergisiso sergisiso Awaiting requested review from sergisiso

Assignees

@arporter arporter

Labels
ready for merge PR is waiting on final CI checks before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arporter @rupertford