Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev-deps): use tilde in typescript #322

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

rwaskiewicz
Copy link
Contributor

@rwaskiewicz rwaskiewicz commented Jun 28, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

use the tilde for typescript versions to match what we do in the rest of the stencil ecosystem. this also fixes a potential bug in the renovate jobs where typescript was being upgraded to 5.1.x.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@rwaskiewicz rwaskiewicz marked this pull request as ready for review June 28, 2023 18:55
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner June 28, 2023 18:55
use the tilde for typescript versions to match what we do in the rest of
the stencil ecosystem. this also fixes a potential bug in the renovate
jobs where typescript was being upgraded to 5.1.x.
@rwaskiewicz rwaskiewicz force-pushed the rwaskiewicz/ts-tilde branch from 89658bf to 59e3302 Compare July 13, 2023 13:22
@rwaskiewicz rwaskiewicz enabled auto-merge (squash) July 13, 2023 13:22
@rwaskiewicz rwaskiewicz merged commit 7474cfe into main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants