Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): group rollup dependencies #377

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

rwaskiewicz
Copy link
Contributor

@rwaskiewicz rwaskiewicz commented Oct 9, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Renovate changes

What is the current behavior?

With the Rollup v4 release, we got a handful of PRs for rollup package bumps. It'd be nice if we just got 1

GitHub Issue Number: N/A

What is the new behavior?

add a groupName to the rollup dependencies to see if that properly creates PRs

Does this introduce a breaking change?

  • Yes
  • No

Testing

Ran renovate-config-validator, but we won't know for sure until this lands

Other information

@rwaskiewicz rwaskiewicz marked this pull request as ready for review October 9, 2023 19:00
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner October 9, 2023 19:00
add a groupName to the rollup dependencies to see if that properly
creates PRs
@rwaskiewicz rwaskiewicz force-pushed the rwaskiewicz/renovate-rollup-group-2 branch from 03ea5ac to 96a88fc Compare October 9, 2023 20:07
@rwaskiewicz rwaskiewicz enabled auto-merge (squash) October 9, 2023 20:07
@rwaskiewicz rwaskiewicz merged commit dfa9715 into main Oct 9, 2023
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/renovate-rollup-group-2 branch October 9, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants