refactor(compiler): destroy callback naming

[sean-perkins]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Unit tests (npm test) were run locally and passed
• E2E Tests (npm run test.karma.prod) were run locally and passed
• Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe): Refactoring a typo in API methods.

What is the current behavior?

Currently the two callbacks for adding and removing callbacks when destroy() is called are misspelled.

• addDestory
• removeDestory

GitHub Issue Number: N/A

What is the new behavior?

Updates the naming to be correctly spelled.

• addDestroy
• removeDestroy

Does this introduce a breaking change?

• Yes
• No

Changes the naming of two public API methods on the Stencil compiler. Developers making use of these methods will need to rename them to the correct spelling.

Testing

Other information

Ignore the branch name, clearly I have issues spelling destroy as well.

[rwaskiewicz]

This LGTM, thanks! CI is failing, but I think that's due to no fault of your own. I need to do some fixup on the v3.0.0-dev branch; when that's done I'll merge this. Thanks again!