Patched the "update-vector-store" and moved the whole function that creates vector stores from rm.py to utils.py #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaoyijia
requested changes
Aug 2, 2024
…nt to check if it's none and raise an error
…confusions when deploying like choosing a wrong model other than the one the vector store was built with or a collection name that is outdated
shaoyijia
approved these changes
Aug 3, 2024
feldges
pushed a commit
to feldges/storm
that referenced
this pull request
Dec 4, 2024
Patched the "update-vector-store" and moved the whole function that creates vector stores from rm.py to utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now users can just create or update vector stores with adding a csv file path without the need for update-vector-store. so this clears confusion.
Also, moved the function that creates and updates the vector stores to utils.py to leave VectorRM only as a retriever.
I also updated the example python script to reflect the changes.