Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang.org/x/net from 0.20.0 to 0.25.0 #672

Merged
merged 2 commits into from
May 30, 2024
Merged

Bump golang.org/x/net from 0.20.0 to 0.25.0 #672

merged 2 commits into from
May 30, 2024

Conversation

antoinerg
Copy link
Contributor

@antoinerg antoinerg commented May 30, 2024

Fixes CVE-2023-45288 present in x/net

EDIT: scanning the image using trivy still reports the CVE above because of stdlib

Copy link

@antoinerg Yikes! You better fix it before anyone else finds out! Build has Failed!

@antoinerg
Copy link
Contributor Author

@antoinerg Yikes! You better fix it before anyone else finds out! Build has Failed!

[nix-shell:~/plotly/Reloader]$ golangci-lint run --out-format=colored-line-number
internal/pkg/controller/controller.go:121:7: previous case (typecheck)
	case *v1.ConfigMap:
	     ^
internal/pkg/controller/controller.go:135:7: previous case (typecheck)
	case *v1.ConfigMap:
	     ^

I don't think the build failure is related to the changes made here ☝️

@antoinerg
Copy link
Contributor Author

@SheryarButt @MuneebAijaz can you help me get this change to the finish line?

Thank you 🙇

Copy link

@antoinerg Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-672-2c4a6d5e\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-672-UBI-2c4a6d5e

@MuneebAijaz MuneebAijaz merged commit 5dea8d2 into stakater:master May 30, 2024
5 checks passed
@antoinerg antoinerg deleted the go_modules/golang.org/x/net-0.25.0 branch May 30, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants