-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(lint): Adds a new template linter to check the restart policy for all deployments like objects #915
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 62.36% 59.03% -3.33%
==========================================
Files 197 201 +4
Lines 4854 5832 +978
==========================================
+ Hits 3027 3443 +416
- Misses 1439 1994 +555
- Partials 388 395 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @rhybrillou and @janisz! Can you spend some time to review this PR? If there's any feedback about this approach, I will be happy to follow up on it 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Overall, the change looks good.
Could you please address the few nitpicks, then the PR should be good to merge from my end.
7a80e84
to
ac26590
Compare
Closes: #609
This PR introduces changes to include a new checker to validate the restart policy for all deployments like objects.