Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(lint): Adds a new template linter to check the restart policy for all deployments like objects #915

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

jonathanmdr
Copy link
Contributor

Closes: #609

This PR introduces changes to include a new checker to validate the restart policy for all deployments like objects.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.03%. Comparing base (dbd7529) to head (75019f7).
Report is 91 commits behind head on main.

Files with missing lines Patch % Lines
...plates/restartpolicy/internal/params/gen-params.go 52.63% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   62.36%   59.03%   -3.33%     
==========================================
  Files         197      201       +4     
  Lines        4854     5832     +978     
==========================================
+ Hits         3027     3443     +416     
- Misses       1439     1994     +555     
- Partials      388      395       +7     
Flag Coverage Δ
unit 59.03% <78.57%> (-3.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathanmdr
Copy link
Contributor Author

Hi @rhybrillou and @janisz!

Can you spend some time to review this PR?

If there's any feedback about this approach, I will be happy to follow up on it 😄

Copy link
Contributor

@rhybrillou rhybrillou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Overall, the change looks good.
Could you please address the few nitpicks, then the PR should be good to merge from my end.

@jonathanmdr jonathanmdr force-pushed the main branch 2 times, most recently from 7a80e84 to ac26590 Compare February 26, 2025 15:32
@rhybrillou rhybrillou merged commit 99380d7 into stackrox:main Feb 26, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE_REQUEST] Support Restart Policy
3 participants