Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to provide HTTP headers, Configure whether to open URLs when validating assets #114

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Allow to provide HTTP headers, Configure whether to open URLs when validating assets #114

merged 4 commits into from
Jan 16, 2025

Conversation

vprivat-ads
Copy link
Contributor

@vprivat-ads vprivat-ads commented Dec 2, 2024 •
edited
Loading

@vprivat-ads vprivat-ads mentioned this pull request Dec 2, 2024
Merged
@vprivat-ads vprivat-ads force-pushed the http_headers branch 3 times, most recently from e4bd703 to bec3513 Compare December 3, 2024 10:28
@vprivat-ads vprivat-ads changed the title Allow to provide HTTP headers Allow to provide HTTP headers, Configure whether to open URLs when validating assets Jan 3, 2025
@vprivat-ads vprivat-ads marked this pull request as ready for review January 3, 2025 15:14
@vprivat-ads
Copy link
Contributor Author

Hi @jonhealy1 (and happy new year!)

I've completed my work on this PR, it is now ready for review.

jonhealy1
jonhealy1 reviewed Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test for these additions. It can similar to the test in stac-validator.

README.md Outdated Show resolved Hide resolved
@vprivat-ads vprivat-ads force-pushed the http_headers branch 3 times, most recently from ee3ab8f to 6627aad Compare January 13, 2025 15:35
@vprivat-ads
Copy link
Contributor Author

Hello @jonhealy1 Everything should be ok now:

  • fixed bug that made the unit tests fail
  • display "No ASSET request errors!" only if assets URLs are being checked
  • update documentation
  • add two new unit tests

jonhealy1
jonhealy1 reviewed Jan 15, 2025
View reviewed changes
README.md Show resolved Hide resolved
jonhealy1
jonhealy1 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thank you!

@jonhealy1 jonhealy1 merged commit 9e35465 into stac-utils:main Jan 16, 2025
6 checks passed
@vprivat-ads vprivat-ads deleted the http_headers branch January 16, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vprivat-ads @jonhealy1