Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor string changes #661

Merged
merged 3 commits into from
Dec 23, 2023
Merged

Minor string changes #661

merged 3 commits into from
Dec 23, 2023

Conversation

sstendahl
Copy link
Owner

@sstendahl sstendahl commented Dec 21, 2023 •
edited
Loading

  • Removes the "hand" suffix for the direction in the axes limits so it's consistent with the rest of the application. (Could use it everywhere instead as well, but I guess removing it is somewhat cleaner)
  • Fixes a capitalization in the subtitle of the text and label size, in the style editor.
  • Removes the X and Y prefix when talking about e.g. "Bottom X axis", as the X/Y part is already implicitly specified when giving the direction.
  • Change "Best" in the legend to "Auto", as the former is a bit confusing imo.

cmkohnen
cmkohnen approved these changes Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@cmkohnen cmkohnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding my comment on the last issue, I haven't read this pr yet.

@cmkohnen cmkohnen merged commit ec88eff into main Dec 23, 2023
6 checks passed
@sstendahl sstendahl deleted the Minor-string-changes branch January 1, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmkohnen cmkohnen cmkohnen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sstendahl @cmkohnen