Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enry-java: Add instructions to include enry-java as a dependency. #122

Merged
merged 2 commits into from
Oct 5, 2017
Merged

enry-java: Add instructions to include enry-java as a dependency. #122

merged 2 commits into from
Oct 5, 2017

Conversation

abeaumont
Copy link
Contributor

Signed-off-by: Alfredo Beaumont alfredo.beaumont@gmail.com

Signed-off-by: Alfredo Beaumont <alfredo.beaumont@gmail.com>
@abeaumont abeaumont self-assigned this Oct 5, 2017
@codecov
Copy link

codecov bot commented Oct 5, 2017

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files          17       17           
  Lines         983      983           
=======================================
  Hits          823      823           
  Misses         98       98           
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3b131...f710460. Read the comment docs.

java/README.md Outdated
<dependency>
<groupId>tech.sourced</groupId>
<artifactId>enry-java</artifactId>
<version>1.0.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should put ${enry_version} or something like that here, to avoid the need of change the readme on every new release.

java/README.md Outdated
### Scala SBT

```scala
libraryDependencies += "tech.sourced" % "enry-java" % "1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here but using enryVersion value

Signed-off-by: Alfredo Beaumont <alfredo.beaumont@gmail.com>
@abeaumont
Copy link
Contributor Author

@ajnavarro changed!

@abeaumont abeaumont closed this Oct 5, 2017
@abeaumont abeaumont reopened this Oct 5, 2017
@abeaumont abeaumont merged commit 59b2393 into src-d:master Oct 5, 2017
@abeaumont abeaumont deleted the feature/enry-java-maven-central-instructions branch October 5, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants