Fix disk read violation for SharedPrefs #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately changing the thread policy didn't work as the next immediately call to read a value from the shared pref creates a violation again. This fixes it by changing the thread from which we trigger the early read, which is probably better anyway because we're not blocking the main thread. Fixes #1984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately changing the thread policy didn't work as the next immediately call to read a value from the shared pref creates a violation again.
This fixes it by changing the thread from which we trigger the early read, which is probably better anyway because we're not blocking the main thread.
Fixes #1984