-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the usages of WorkManager's SettableFuture #2650
Comments
@kuanyingchou Do you have a suggestion on what to replace it with? I don't mind updating, just need some guidance on how to implement That being said, even after updating, it'll still be in older releases of LeakCanary. I'm also surprised because that class has |
Conversation in ASG for anyone who has access: https://androidstudygroup.slack.com/archives/CAYMXJE0H/p1713384243471319 |
Updating the WorkManager version to `2.8.0` which added `Worker.getForegroundInfo` ([release notes](https://developer.android.com/jetpack/androidx/releases/work#2.8.0)) which removes the need to mess with `ListenableFuture`. Fixes #2650
Updating the WorkManager version to `2.8.0` which added `Worker.getForegroundInfo` ([release notes](https://developer.android.com/jetpack/androidx/releases/work#2.8.0)) which removes the need to mess with `ListenableFuture`. Fixes #2650
Updating the WorkManager version to `2.9.0` which added `Worker.getForegroundInfo` ([release notes](https://developer.android.com/jetpack/androidx/releases/work#2.8.0)) which removes the need to mess with `ListenableFuture`. Also add (implicit in 2.9.0) dependency on futures so that we can use `CallbackToFutureAdapter` when extending `RemoteListenableWorker` which does not offer a `getForegroundInfo` implementation. Fixes #2650
Updating the WorkManager version to `2.9.0` which added `Worker.getForegroundInfo` ([release notes](https://developer.android.com/jetpack/androidx/releases/work#2.8.0)) which removes the need to mess with `ListenableFuture`. Also add (implicit in 2.9.0) dependency on futures so that we can use `CallbackToFutureAdapter` when extending `RemoteListenableWorker` which does not offer a `getForegroundInfo` implementation. Fixes #2650
Updating the WorkManager version to `2.9.0` which added `Worker.getForegroundInfo` ([release notes](https://developer.android.com/jetpack/androidx/releases/work#2.8.0)) which removes the need to mess with `ListenableFuture`. Also add (implicit in 2.9.0) dependency on futures so that we can use `CallbackToFutureAdapter` when extending `RemoteListenableWorker` which does not offer a `getForegroundInfo` implementation. Fixes #2650
Updating the WorkManager version to `2.9.0` which added `Worker.getForegroundInfo` ([release notes](https://developer.android.com/jetpack/androidx/releases/work#2.8.0)) which removes the need to mess with `ListenableFuture`. Also add (implicit in 2.9.0) dependency on futures so that we can use `CallbackToFutureAdapter` when extending `RemoteListenableWorker` which does not offer a `getForegroundInfo` implementation. Fixes #2650
Adding `LazyImmediateFuture` which removes the need to use `SettableFuture`. Fixes #2650
Adding `LazyImmediateFuture` which removes the need to use `SettableFuture`. Fixes #2650
Problem description
Hi, we would like to remove
SettableFuture
from WorkManager but found that LeakCanary is using it:/~https://github.com/search?q=repo%3Asquare%2Fleakcanary%20settablefuture&type=code
Potential solutions
Is it possible to remove the usages of
SettableFuture
as it's WorkManager's internal API?Additional information
Here's our change in WorkManager: https://android-review.googlesource.com/c/platform/frameworks/support/+/3000016/1
The text was updated successfully, but these errors were encountered: