Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show matched pattern for library leaks directly in leaktrace #1916

Closed
pyricau opened this issue Sep 2, 2020 · 0 comments · Fixed by #1934
Closed

Show matched pattern for library leaks directly in leaktrace #1916

pyricau opened this issue Sep 2, 2020 · 0 comments · Fixed by #1934
Labels
type: enhancement
Milestone
2.5

Comments

@pyricau
Copy link
Member

pyricau commented Sep 2, 2020

Devs often share only a subset of the leakcanary output, which often doesn't include the library leak pattern. We can work around that by output the pattern where it matches, directly in the leaktrace.
pyricau added a commit that referenced this issue Sep 17, 2020
@pyricau
Add library leak pattern to leaktrace rendering
b1031ea 
As people tend to share only part of a leaktrace, this will help surface library leaks when someone shares one.

Fixes #1916
@pyricau pyricau mentioned this issue Sep 17, 2020
Merged
@pyricau pyricau added this to the 2.5 milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

Add library leak pattern to leaktrace rendering square/leakcanary
1 participant
@pyricau