Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Stop reporting retained size #1011

Closed
pyricau opened this issue Jun 18, 2018 · 2 comments
Closed

[Perf] Stop reporting retained size #1011

pyricau opened this issue Jun 18, 2018 · 2 comments
Milestone
1.6.1

Comments

@pyricau
Copy link
Member

pyricau commented Jun 18, 2018

A quick test showed that the vast majority of the time on my Pixel2 was spent computing dominators, which is needed to calculate the retained size.

Maybe we should stop computing retained size, or maybe we could make that optional, or async.
@pyricau pyricau added this to the 1.6 milestone Jun 18, 2018
pyricau added a commit that referenced this issue Jun 18, 2018
@pyricau
Stop computing Retained Size by default
ede45c1 
It turns out computing the retained size is really slow. This change turns it off by default (can be turned on if needed). LeakCanary is much faster now!

Fixes #1011
@pyricau pyricau mentioned this issue Jun 18, 2018
Merged
pyricau added a commit that referenced this issue Jun 18, 2018
@pyricau
Stop computing Retained Size by default
b52501b 
It turns out computing the retained size is really slow. This change turns it off by default (can be turned on if needed). LeakCanary is much faster now!

Fixes #1011
pyricau added a commit that referenced this issue Jun 19, 2018
@pyricau
Stop computing Retained Size by default
b17f918 
It turns out computing the retained size is really slow. This change turns it off by default (can be turned on if needed). LeakCanary is much faster now!

Fixes #1011
@ashima0512
Copy link

Is there any API to turn this feature on if I really need the size so that I know which leak is the worst one?

@pyricau
Copy link
Member Author

pyricau commented Nov 16, 2018 •
edited
Loading

@ashima0512 RefWatcherBuilder.computeRetainedHeapSize()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.1
Development

No branches or pull requests
2 participants
@pyricau @ashima0512