Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change default installers assets download URL (Windows) #18548

Merged
merged 4 commits into from
Jul 5, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Jul 4, 2022

Description of Changes

  • Change default URL for Windows installer assets to be the latest release available on the window-installer-assets repository

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v5.3.2 milestone Jul 4, 2022
@dalthviz dalthviz self-assigned this Jul 4, 2022
@dalthviz dalthviz changed the title [[WIP] PR: Change default assets download URL and add documentation for testing with Github Workflow (Windows) [WIP] PR: Change default assets download URL and add documentation for testing with Github Workflow (Windows) Jul 4, 2022
@dalthviz dalthviz force-pushed the default_win_installer_assets branch from 45f41a4 to c2b57f8 Compare July 4, 2022 18:56
@dalthviz dalthviz force-pushed the default_win_installer_assets branch from 72f6564 to c6baf2d Compare July 4, 2022 19:23
@dalthviz dalthviz changed the title [WIP] PR: Change default assets download URL and add documentation for testing with Github Workflow (Windows) [WIP] PR: Change default assets download URL (Windows) Jul 4, 2022
@dalthviz dalthviz changed the title [WIP] PR: Change default assets download URL (Windows) [WIP] PR: Change default installers assets download URL (Windows) Jul 4, 2022
@dalthviz dalthviz changed the title [WIP] PR: Change default installers assets download URL (Windows) PR: Change default installers assets download URL (Windows) Jul 4, 2022
@dalthviz dalthviz requested a review from ccordoba12 July 4, 2022 19:28
@dalthviz
Copy link
Member Author

dalthviz commented Jul 4, 2022

Note: Not totally sure but most probably a similar change as the last commit here (c6baf2d) could be needed for the MacOS installer workflow. Seems like the installer workflows are not running at all like for example at #18544

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalthviz, I left a tiny suggestion for you, otherwise looks good to me.

@dalthviz dalthviz mentioned this pull request Jul 5, 2022
4 tasks
dalthviz and others added 2 commits July 5, 2022 11:32
@dalthviz dalthviz force-pushed the default_win_installer_assets branch from 5d44284 to dd368e6 Compare July 5, 2022 16:36
@dalthviz dalthviz requested a review from ccordoba12 July 5, 2022 17:15
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit a626f8d into spyder-ide:5.x Jul 5, 2022
ccordoba12 added a commit that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants