Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add a minimal test #43

Merged
merged 19 commits into from
Mar 26, 2017
Merged

PR: Add a minimal test #43

merged 19 commits into from
Mar 26, 2017

Conversation

dalthviz
Copy link
Member

Fixes #41

@dalthviz dalthviz added this to the v0.1 milestone Mar 12, 2017
@dalthviz dalthviz self-assigned this Mar 12, 2017
@ccordoba12
Copy link
Member

@dalthviz, you need to edit circle.yml to make our tests run in CircleCI.

Please also add a test that verifies that the page shown in NotebookWidget is actually a notebook (by inspecting some of its DOM div's or classes).

@dalthviz dalthviz force-pushed the fixes_issue_41 branch 2 times, most recently from fa7823f to 2fd98e0 Compare March 25, 2017 18:09
@ccordoba12
Copy link
Member

@dalthviz, I'm going to fix this. Don't worry about it :-)

@ccordoba12 ccordoba12 changed the title PR: Add tests for the plugin PR: Add a minimal test Mar 26, 2017
@ccordoba12
Copy link
Member

We need to add more tests, but let's merge this one for now.

@ccordoba12 ccordoba12 merged commit c7bc357 into spyder-ide:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dalthviz dalthviz

Labels
type:Task
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dalthviz @ccordoba12