PR: Use GitHub Actions to do automatic testing #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=========================================
Coverage ? 74.18%
=========================================
Files ? 8
Lines ? 550
Branches ? 0
=========================================
Hits ? 408
Misses ? 142
Partials ? 0 Continue to review full report at Codecov.
|
jitseniesen
changed the title
goanpeca
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
Awesome @jitseniesen ! thanks for working on this!
Looks good to me :-)
|
This is really nice, great work @jitseniesen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from CircleCI to GitHub Actions for automatic testing.
It adds automatic testing on Windows and MacOS. One of the tests hung on these OSes, so that test is skipped. Tests are also not run for Python 2.7 under Windows, because pytest segfaults there. I think it is not essential to fix these issues, given that we did not have testing on Windows and MacOS before, and Python 2.7 is end of line.
Thanks to @goanpeca for getting this to work on spyder-kernels which was a good start for me.
Fixes #241