Process @Parameters method parameters as Spring MergedAnnotations

[jryan128]

I noticed you used merged annotations while reading method annotations but not method parameters.
This allows the creation of Spring Merged annotations to avoid repeating ourselves:

@Target({PARAMETER, ANNOTATION_TYPE})
@Retention(RetentionPolicy.RUNTIME)
@Parameter(name = "accountId")
public @interface AccountId {
    @AliasFor(annotation = Parameter.class, value = "example")
    String example() default "123456";
}

...

@GetMapping(value = "/example", produces = MediaType.APPLICATION_JSON_VALUE)
@Operation(description = "example")
public Mono<Void> example(@PathVariable @AccountId String accountId) ...

I'll add tests if the maintainers think it's a good idea. Thanks!

[bnasslahsen]

Hi @jryan128,

Thank you for your contribution.
This feature seems interesting, but we need to keep compatiblity with older versions of spring as well.

Can you also keep the compatibility with spring-boot 1, because MergedAnnotations is only available since spring v5.2.

You can test it against the following example:

• /~https://github.com/springdoc/springdoc-openapi-demos/tree/master/springdoc-openapi-spring-boot-1

[jryan128]

Sure thing!

…

On Sat, May 16, 2020, 14:44 bnasslahsen ***@***.***> wrote: ***@***.**** requested changes on this pull request. Hi @jryan128 </~https://github.com/jryan128>, Thank you for your contribution. This feature seems interesting, but we need to keep compatiblity with older versions of spring as well. Can you also keep the compatibility with spring-boot 1, because MergedAnnotations is only available since spring v5.2. You can test it against the following example: - /~https://github.com/springdoc/springdoc-openapi-demos/tree/master/springdoc-openapi-spring-boot-1 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#668 (review)>, or unsubscribe </~https://github.com/notifications/unsubscribe-auth/AAE4JYVQ3WK7K75WUTLN4V3RR3NHDANCNFSM4M72EBDQ> .

[jryan128]

After falling back to AnnotatedElementUtils, the Spring Boot 1 demo works fine. Please take a look. If you like the change and want to merge it let me know and I'll add more tests around it.

[bnasslahsen]

Hi @jryan128,

It looks great. Can you please add some tests?
Once its ready, i will do the merge.

[jryan128]

Ready for review.

[bnasslahsen]

Great contribution @jryan128 👍

Thank you for this nice enhancement.
Its now merged with master.