Use ObjectProvider
to inject RequestMappingInfoHandlerMapping
#1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed failures in some Spring Boot tests in the Springdoc 1.5.11 upgrade PR.
In v1.5.11,
SwaggerWelcomeWebMvc
injects an optionalRequestMappingInfoHandlerMapping
, however it's possible to have multiple beans for that type. For instance, it's not uncommon to haveControllerEndpointHandlerMapping
in addition toRequestMappingHandlerMapping
.This change uses
ObjectProvider
instead so that we can handle multiple beans.The exception we get:
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'swaggerWelcome' defined in class path resource [org/springdoc/webmvc/ui/SwaggerConfig.class]: Unsatisfied dependency expressed through method 'swaggerWelcome' parameter 3; nested exception is org.springframework.beans.factory.NoUniqueBeanDefinitionException: No qualifying bean of type 'org.springframework.web.servlet.mvc.method.RequestMappingInfoHandlerMapping' available: expected single matching bean but found 3: requestMappingHandlerMapping,webEndpointServletHandlerMapping,controllerEndpointHandlerMapping
Relates to #1258 and 6e709c9.