Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for find using predicate/pageable that returns a Slice [DATACMNS-541] #1011

Closed
spring-projects-issues opened this issue Jul 16, 2014 · 4 comments
Assignees
Labels
in: repository Repositories abstraction type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Seshu Pasam opened DATACMNS-541 and commented

Am using QueryDslPredicateExecutor. What I really need is following method:

Slice<T> findAll(Predicate predicate, Pageable pageable);

The reason I don't want to use findAll that returns Page<T> is because it has twice the overhead (for performing the count operation). I am using spring-data mongodb 1.5.1


Affects: 1.8 GA (Dijkstra)

Issue Links:

  • DATAJPA-289 Add findAll(Predicate, Pageable) method to QueryDslPredicateExecutor that returns only List/Iterable

  • DATACMNS-548 Add documentation of Slice for repository query methods

7 votes, 5 watchers

@spring-projects-issues spring-projects-issues added in: repository Repositories abstraction status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement labels Dec 30, 2020
@mp911de mp911de changed the title Add support for find using predicate/pageable that returns a slice [DATACMNS-541] Add support for find using predicate/pageable that returns a Slice [DATACMNS-541] Nov 9, 2021
@mp911de
Copy link
Member

mp911de commented Nov 9, 2021

With #2228 we introduced a fluent API for Querydsl and Query by Example and it would be neat to have a Slice<T> slice(Pageable) method in addition to Page<T> page(Pageable).

@membersound
Copy link

membersound commented Jul 26, 2022

Still no work on this? It is critical for large datasets, as the count query then makes a traditional Page approach unusable!

@simasch
Copy link

simasch commented Jan 3, 2023

Will this be implemented eventually?

@reactivestudio
Copy link

Also need this feature. Will it be implemented?

@mp911de mp911de self-assigned this Feb 5, 2025
@mp911de mp911de added this to the 3.5 M1 (2025.0.0) milestone Feb 5, 2025
@mp911de mp911de removed status: ideal-for-contribution An issue that a contributor can help us with theme: 3.1 labels Feb 5, 2025
@mp911de mp911de closed this as completed in eefb1dc Feb 5, 2025
mp911de added a commit that referenced this issue Feb 5, 2025
Refine Pageable sort override.

See #1011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository Repositories abstraction type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants