Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Plan objects provided in Request objects #141

Closed
scottfrederick opened this issue Dec 17, 2018 · 0 comments
Closed

Filter Plan objects provided in Request objects #141

scottfrederick opened this issue Dec 17, 2018 · 0 comments
Assignees
@royclarkson
Labels
accepted enhancement
Milestone
2.1.0.RC1

Comments

@scottfrederick
Copy link
Contributor

Most of the Request objects created for OSB request endpoints (CreateServiceInstanceRequest, UpdateServiceInstanceRequest, DeleteServiceInstanceRequest, CreateServiceInstanceBindingRequest, DeleteServiceInstanceBindingRequest) include a ServiceDefinition object. SC OSB inspects the incoming request and automatically extracts the appropriate ServiceDefinition from the Catalog as a convenience to the services.

If a service definition includes multiple plans, all of the Plan objects from the catalog are included in the provided ServiceDefinition object. It would be better if SC OSB filtered out all but the Plan objects except the one that matches the request input.
@royclarkson royclarkson self-assigned this Dec 17, 2018
royclarkson added a commit to royclarkson/spring-cloud-open-service-broker that referenced this issue Dec 18, 2018
@royclarkson
Filter Plan objects provided in Request objects
2e8c60e 
Resolves spring-cloud#141
@royclarkson royclarkson mentioned this issue Dec 18, 2018
Merged
@royclarkson royclarkson added this to the 2.1.0.RC1 milestone Dec 18, 2018
royclarkson added a commit to royclarkson/spring-cloud-open-service-broker that referenced this issue Dec 19, 2018
@royclarkson
Filter Plan objects provided in Request objects
0857456 
Resolves spring-cloud#141
royclarkson added a commit that referenced this issue Dec 19, 2018
@royclarkson
Filter Plan objects provided in Request objects
e88d839 
Resolves #141
@aclement aclement removed the review label Dec 19, 2018
royclarkson added a commit that referenced this issue Dec 21, 2018
@royclarkson
Filter Plan objects provided in Request objects
afc6068 
Resolves #141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@royclarkson royclarkson

Labels
accepted enhancement
Projects
None yet
Milestone
2.1.0.RC1
Development

No branches or pull requests
4 participants
@royclarkson @scottfrederick @aclement @csterwa