Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up output order #164

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Cleaning up output order #164

merged 1 commit into from
Jun 18, 2024

Conversation

ljstella
Copy link
Contributor

  1. Removes extra fields that we don't want that were missed before
  2. sorts the output! Technically, order doesn't matter in YAML. But given that we're generating a skeleton that we expect people to manually add/edit, we should create a file that's consistent with what we expect.

@ljstella ljstella requested a review from pyth0n1c June 17, 2024 19:01
@ljstella ljstella self-assigned this Jun 17, 2024
@pyth0n1c pyth0n1c changed the base branch from main to release_v4.1.0 June 18, 2024 23:44
pyth0n1c
pyth0n1c approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User interface and output files all look correct.
Of course they still fail validation, but this is intentional
as the user needs to update them.

@pyth0n1c pyth0n1c merged commit 28219ea into release_v4.1.0 Jun 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyth0n1c pyth0n1c pyth0n1c approved these changes

Assignees

@ljstella ljstella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljstella @pyth0n1c