Port v1 tests to v2 #1980
Merged
Port v1 tests to v2 #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
approved these changes
Jan 16, 2025
|
@joseph-isaacs looks like there's bugs in expression partitioning. We incorrectly evaluate or's and and's and seems we are missing some fields? |
|
The failed test seems to have the filter removed or the assertion not adjusted. I can look at adding the filters back |
|
I indeed missed filter in 3 cases. However, after adding them back the queries are still failing albeit with unknown field names. |
|
eh, why do we still have column when v2 doesn't support it? Ok this is now fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.