Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagram filenames, make them display properly #989

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 10, 2024

Remove spaces from filenames to make model images displayed properly.

Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall added this to the 3.0.1 milestone Aug 9, 2024
@bact bact requested a review from kestewart August 9, 2024 19:13
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the quick updates.

@goneall
Copy link
Member

goneall commented Aug 9, 2024

@bact - can you rebase to the latest - merge is showing conflicts

@bact
Copy link
Collaborator Author

bact commented Aug 9, 2024

@goneall, again, I can't rebase it -- please use PR #1033 instead

@bact bact closed this Aug 9, 2024
@bact bact deleted the cleanup-markdown-2 branch August 9, 2024 20:53
@bact bact restored the cleanup-markdown-2 branch August 9, 2024 21:35
@bact bact reopened this Aug 9, 2024
bact added 2 commits August 9, 2024 22:39
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact force-pushed the cleanup-markdown-2 branch from ff815e4 to fd648ee Compare August 9, 2024 21:41
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@goneall goneall merged commit 001f467 into spdx:development/v3.0.1 Aug 9, 2024
3 checks passed
@bact bact deleted the cleanup-markdown-2 branch August 9, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants