Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New diagrams #1159

Merged
merged 2 commits into from
Dec 9, 2024
Merged

New diagrams #1159

merged 2 commits into from
Dec 9, 2024

Conversation

zvr
Copy link
Member

@zvr zvr commented Dec 6, 2024

This updates the diagrams (used in the first Annex) to the latest version generated in the model repo.

Signed-off-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
@zvr zvr added this to the 3.0.1 milestone Dec 6, 2024
@zvr zvr requested review from bact and goneall December 6, 2024 10:18
@goneall
Copy link
Member

goneall commented Dec 6, 2024

From a very cursory review, looks fine.

I'm going to do a more detailed check on the changes since the last diagram update this morning.

…nship

Signed-off-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update more later on ordering of entries. But this is good for now.

@bact
Copy link
Collaborator

bact commented Dec 9, 2024

Validation failed from an known issue and irrelevant to this PR. Will merge

@bact bact merged commit cbb3aac into spdx:develop Dec 9, 2024
2 of 3 checks passed
@bact bact added profile: licensing Licensing Profile and related matters profile: core Core Profile and related matters profile: ai AI Profile and related matters profile: dataset Dataset Profile and related matters labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profile: ai AI Profile and related matters profile: core Core Profile and related matters profile: dataset Dataset Profile and related matters profile: licensing Licensing Profile and related matters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants