-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the generated RDF files #1067
Conversation
Signed-off-by: Alexios Zavras <github@zvr.gr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it possible to take this opportunity that the URL is going to change anyway (because of the patch version update), to have this file rdf/spdx-model.json-ld
renamed to rdf/spdx-model.jsonld
please?
The reason is, with that we can have the extension that is consistent with rdf/spdx-context.jsonld
and authors will not have to remember when to use .json-ld
or when to use .jsonld
.
I have checked in both spdx-spec and spdx-3-model repos,
- there are at least 25 instances of
spdx-context.jsonld
- there's only one instance of
spdx-model.json-ld
, which is in the README section, and not the spec or the code:
Lines 156 to 162 in 399bbf5
This will create well-formatted model files in the `spdx-spec/docs/model/` directory. This directory contains two components: - Model ontology and diagram files: These files (`model.plantuml`, `spdx-context.jsonld`, `spdx-model.dot`, `spdx-model.json-ld`, `spdx-model.pretty-xml`, `spdx-model.ttl`, `spdx-model.xml`) are ready for immediate use.
Current instances that reference to the SPDX model usespdx-model.ttl
.
This means the change to standardize .jsonld
will not be a breaking one.
Thank you for generating and adding these files back.
Of course the filename can easily be changed, but let's be careful here: The idea is to simply have them for people to view (most probably via the GitHub web UI). It should not be considered a distribution mechanism of generated artifacts. |
Thanks. +1 on "It should not be considered a distribution mechanism of generated artifacts." I think in general, some consistency/common expectability will help us the developers as well, not only the "end-users". |
Signed-off-by: Alexios Zavras <github@zvr.gr>
I've now added all the various formats that RDF data can be automatically generated. |
Thank you. I think we can merge this. |
We used to have a top-level directory
ontology
in this repo, containing the RDF data. It was removed because it was stale.This PR adds this data back, in a new top-level directory named
rdf
.This includes the ontology, but also the JSON-LD context file.
Signed-off-by: Alexios Zavras github@zvr.gr