Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX Lite annex #1061

Merged
merged 4 commits into from
Aug 12, 2024
Merged

SPDX Lite annex #1061

merged 4 commits into from
Aug 12, 2024

Conversation

zvr
Copy link
Member

@zvr zvr commented Aug 12, 2024

This re-words the Lite annex to make it easier to understand the mandatory and recommended properties defined.

It also changes the format to use lists instead of tables, so that it can be generated in PDF.

Signed-off-by: Alexios Zavras github@zvr.gr

Signed-off-by: Alexios Zavras <github@zvr.gr>
@zvr zvr added this to the 3.0.1 milestone Aug 12, 2024
@zvr
Copy link
Member Author

zvr commented Aug 12, 2024

@NorioKobota please take a look

@NorioKobota
Copy link
Contributor

@zvr Thanks, looks great.

@zvr zvr requested review from bact, goneall and kestewart August 12, 2024 09:58
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @NorioKobota, make 4-space indent for nested list, for compatibility with both GitHub and MkDocs.

Also add a blank line between the headings and the following list, to ensure a proper display of the list on MkDocs.

Apart from the format, the content itself is good and ready to get approved.

Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
zvr and others added 2 commits August 12, 2024 14:45
Signed-off-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Kate Stewart <13152682+kestewart@users.noreply.github.com>
Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, and spacing adjusted.

@goneall goneall merged commit 63b1eab into spdx:development/v3.0.1 Aug 12, 2024
3 checks passed
@zvr zvr mentioned this pull request Aug 28, 2024
@zvr zvr deleted the lite branch September 6, 2024 08:31
@bact bact added the profile: lite Lite Profile and related matters label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profile: lite Lite Profile and related matters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants