Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO Foreword #1001

Merged
merged 5 commits into from
Aug 10, 2024
Merged

Add ISO Foreword #1001

merged 5 commits into from
Aug 10, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 24, 2024

  • Text from Bob's Word doc 2024-07-22
  • Add once ISO JTC-1 approves and we are sending final spec to ISO
    • It is possible to be merge this first, without include this file to the chapter list in mkdocs.yml (currently the mkdocs.yml doesn't include this)
    • Once the final spec was sent, we can include the file to mkdocs.yml

This PR will supersede #974

@bact bact mentioned this pull request Jul 25, 2024
69 tasks
Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall added this to the 3.0.1 milestone Aug 9, 2024
In the IEC, see
[www.iec.ch/understanding-standards](https://www.iec.ch/understanding-standards).

This document was prepared by the Object Management Group (OMG) (as SPDX®
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be mentioning both organizations here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kestewart another one is The Linux Foundation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using the following:

This document was prepared by The Linux Foundation under the SPDX Working Group (as SPDX® Specification v3.0.1) and drafted in accordance with its editorial rules. Its preparation and publication has been made in coordination with related efforts with the Object Management Group (OMG).

@bobmartin3000 @kestewart Are you comfortable with this phrasing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swinslow I have added your suggestion to the source, with additional "and its Contributors" which I take from the copyright line from #1010

@kestewart kestewart requested review from zvr and goneall August 9, 2024 18:34
@swinslow
Copy link
Member

swinslow commented Aug 9, 2024

I just added a comment with proposed edits to the language that @kestewart flagged.

I'll ask also (but will defer to the tech team as I'm definitely not close to the details here!) -- it sounds like this language wouldn't be incorporated unless and until it's actually approved by ISO / JTC. Is that correct? Just making sure we aren't publishing something saying "this is approved by ISO" if it isn't actually yet. :)

@bobmartin3000
Copy link

bobmartin3000 commented Aug 9, 2024 via email

@bobmartin3000
Copy link

bobmartin3000 commented Aug 9, 2024 via email

bact added 4 commits August 9, 2024 22:07
Text from Bob's Word doc 2024-07-22

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact force-pushed the add-chap-foreword branch from 42860cc to 8ec8873 Compare August 9, 2024 21:11
@bact bact requested a review from kestewart August 9, 2024 22:16
Copy link
Member

@swinslow swinslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, thank you @bact!

@kestewart kestewart merged commit 17c1166 into spdx:development/v3.0.1 Aug 10, 2024
3 checks passed
@bact bact deleted the add-chap-foreword branch August 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants