Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for closing the file manually when necessary #155

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

RayDabbah
Copy link
Contributor

I came across a situation where I was trying to write to an Excel file but the file was empty. The reason was that for Excel files the file doesn't get written until the destructor is called. So I figured I'll make a PR to add it to the documentation.

@freekmurze freekmurze merged commit 1bce12e into spatie:main Oct 31, 2023
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants