Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Convert PHPUnit tests to PestPHP #456

Merged

Conversation

mansoorkhan96
Copy link
Contributor

@mansoorkhan96 mansoorkhan96 commented Apr 30, 2022

This Pull Request converts PHPUnit tests to PestPHP. It also refactors a few things like:

 $this->app['config']->set('...');

TO

config()->set('...');

Feel free to ask for any changes :)

@freekmurze freekmurze merged commit f793546 into spatie:main May 2, 2022
@freekmurze
Copy link
Member

This is great, thank you!

@mansoorkhan96
Copy link
Contributor Author

This is great, thank you!

Hey @freekmurze Thank for you merging. I know you love Pest. Hopefully, I will be sending a similar PR to your other packages too 🚀

@mansoorkhan96 mansoorkhan96 deleted the feature/convert-phpunit-tests-pestphp branch May 5, 2022 09:11
@mansoorkhan96 mansoorkhan96 restored the feature/convert-phpunit-tests-pestphp branch May 5, 2022 09:11
@mansoorkhan96 mansoorkhan96 deleted the feature/convert-phpunit-tests-pestphp branch May 5, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants