Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: rename pyo3_branchwater to sourmash_plugin_branchwater #156

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Nov 29, 2023

Fixes #17

@ctb ctb changed the title WIP: rename pyo3_branchwater to sourmash_plugin_branchwater MRG: rename pyo3_branchwater to sourmash_plugin_branchwater Nov 29, 2023
@ctb
Copy link
Collaborator Author

ctb commented Nov 29, 2023

@mr-eyes @luizirber @bluegenes any concerns about me merging this and cutting a new release, to get that PyPI name claimed? Then I'll revisit #152.

@mr-eyes
Copy link
Member

mr-eyes commented Nov 29, 2023

Actually it makes more sense removing the pyo3 word. This is a mega plugin that I hope it gets integrated into the sourmash core one day. Good to me 👍

@ctb
Copy link
Collaborator Author

ctb commented Nov 29, 2023

This is a mega plugin that I hope it gets integrated into the sourmash core one day

yep! From the README:

Future thoughts

The speed and functions of this code will probably be brought into sourmash core in the future, most likely as part of sourmash-bio/sourmash#2230. However, in the meantime, this is a fun side project that makes use of sourmash plugins and Rust to provide some fast functionality that may be of use to some people, and it can serve as a testbed for future sourmash functionality.

I think there are a few bits and bobs that won't ever make it in - I'm looking at multisearch ;) - but otherwise, yes!

@ctb ctb mentioned this pull request Nov 29, 2023
@bluegenes
Copy link
Contributor

sure, sounds good!

@ctb ctb merged commit ed9ca0d into main Nov 30, 2023
1 check passed
@ctb ctb deleted the rename branch November 30, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename package
3 participants