Added seed to parameter strings #1732 #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #2836 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 130 130
Lines 14752 14752
Branches 2623 2623
=======================================
Hits 12725 12725
Misses 1726 1726
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi. I am new to this. @luizirber Can you please help me understand the issue? I am not able to figure it out. |
Everything looks good to me! I just approved GitHub Actions to run on this PR. |
ctb
approved these changes
Nov 17, 2023
|
merging when tests pass |
ctb
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 'seed' to parameter string in doc/sourmash-sketch.md as per #1732 . Fixes #1732 .