Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: run rust checks always #2787

Merged
merged 1 commit into from
Sep 27, 2023
Merged

MRG: run rust checks always #2787

merged 1 commit into from
Sep 27, 2023

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Sep 27, 2023

Fixes #2550

There were some concerns about how long things take to run, so we'll evaluate that and maybe revert this change if it slows down PRs.

Alternatively, we could implement #2342 and make better use of draft PRs.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2787 (fbaeb8a) into latest (c2d1d15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           latest    #2787   +/-   ##
=======================================
  Coverage   85.94%   85.94%           
=======================================
  Files         130      130           
  Lines       14808    14808           
  Branches     2621     2621           
=======================================
  Hits        12727    12727           
  Misses       1780     1780           
  Partials      301      301           
Flag Coverage Δ
hypothesis-py 25.82% <ø> (ø)
python 92.85% <ø> (ø)
rust 49.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor Author

ctb commented Sep 27, 2023

The longest rust checks take 22m.

I'd say, let's merge this, and we can refactor to just run on final PRs if it becomes a problem.

@sourmash-bio/devs ready for review!

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22 min is pretty long, but the try-then-refactor approach sounds good to me

@ctb ctb merged commit 966c045 into latest Sep 27, 2023
@ctb ctb deleted the fix/rust_ci branch September 27, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"minimum rust version" CI checks are not being run
2 participants