Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov from tox, use GH action instead #2568

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

luizirber
Copy link
Member

Fixes #2567

Remove codecov from tox, and use the GitHub Action for uploading coverage for Python tests (and hypothesis too, I don't think they were being uploaded...)

@ctb
Copy link
Contributor

ctb commented Apr 12, 2023

🙇‍♂️

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #2568 (3903a4e) into latest (fe79fc1) will increase coverage by 7.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2568      +/-   ##
==========================================
+ Coverage   85.19%   92.82%   +7.63%     
==========================================
  Files         133      104      -29     
  Lines       15169    12380    -2789     
  Branches     2610     2610              
==========================================
- Hits        12923    11492    -1431     
+ Misses       1945      587    -1358     
  Partials      301      301              
Flag Coverage Δ
hypothesis-py 25.83% <ø> (?)
python 92.82% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luizirber luizirber merged commit 59d5e7c into latest Apr 13, 2023
@luizirber luizirber deleted the lirber/codecov_action branch April 13, 2023 00:41
ctb added a commit to dib-lab/screed that referenced this pull request Apr 16, 2023
codecov switched the mechanism for uploading coverage; see
sourmash-bio/sourmash#2567.

fixing as per sourmash-bio/sourmash#2568.
@ctb ctb mentioned this pull request Apr 17, 2023
12 tasks
ctb added a commit that referenced this pull request Apr 17, 2023
## release checklist

Release candidate testing:
- [ ] Command line tests pass for a release candidate
- [ ] All eight release candidate wheels are built

Releasing to PyPI:

- [ ] RC tag(s)s deleted on github
- [ ] Release tag cut
- [ ] Release notes written
- [ ] All eight release wheels built
- [ ] Release wheels uploaded to pypi
- [ ] tar.gz distribution uploaded to pypi

After release to PyPI and conda-forge/bioconda packages built:

- [ ] [PyPI page](https://pypi.org/project/sourmash/) updated
- [ ] Zenodo DOI successfully minted upon new github release - [see
search
results](https://zenodo.org/search?page=1&size=20&q=sourmash&sort=mostrecent)
- [ ] `pip install sourmash` installs the correct version
- [ ] `mamba create -n smash-release -y sourmash` installs the correct
version

## release docs

Minor new features:

* add --create-empty-results option to gather (#2557)

Bug fixes:

* fix exception error when no arguments are provided to `sig intersect`
(#2555)

Cleanup and documentation updates:

* update `sourmash sketch` docs for building merged sketches (#2563)
* fix broken crates.io badge (#2556)
* add --csv to command-line docs for `compare` (#2565)

Developer updates:

* Remove codecov from tox, use GH action instead (#2568)

Dependabot updates:

* Update pytest requirement from <7.3.0,>=6.2.4 to >=6.2.4,<7.4.0
(#2558)
* Bump tempfile from 3.4.0 to 3.5.0 (#2561)
* Bump serde from 1.0.158 to 1.0.159 (#2560)
* Bump getrandom from 0.2.8 to 0.2.9 (#2559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update codecov to make CI/github actions continue to work
2 participants