[MRG] Update python version per deprecation policy #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #2286 +/- ##
==========================================
+ Coverage 84.82% 92.14% +7.32%
==========================================
Files 131 100 -31
Lines 15676 11400 -4276
Branches 2251 2251
==========================================
- Hits 13297 10505 -2792
+ Misses 2085 601 -1484
Partials 294 294
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ctb
approved these changes
Sep 21, 2022
| @@ -8,7 +8,7 @@ Michael Crusoe. | |||
| The basic build environment needed below can be created as follows: | |||
|
|
|||
| ``` | |||
| conda create -y -n sourmash-rc python=3.8 pip cxx-compiler make twine tox tox-conda setuptools setuptools_scm | |||
| conda create -y -n sourmash-rc python=3.10 pip cxx-compiler make twine tox tox-conda setuptools setuptools_scm | |||
There was a problem hiding this comment.
yep - it's good to put the python version explicitly here, because we want to control the version when cutting a release.
Co-authored-by: C. Titus Brown <titus@idyll.org>
ctb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2285
README.mdand changed python version to 3.10 indoc/release.md