Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] use stderr for test output printing #2217

Merged
merged 2 commits into from
Aug 19, 2022
Merged

[MRG] use stderr for test output printing #2217

merged 2 commits into from
Aug 19, 2022

Conversation

bluegenes
Copy link
Contributor

Sets sys.stdout=sys.stderr, per #2138 (comment). Suggested as a solution to pytest-xdist not printing test output here: pytest-dev/pytest-xdist#354 (comment)

restores test output printing

@ctb is this a desired solution? Or did you find a better workaround?

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #2217 (ce0f648) into latest (651ecea) will increase coverage by 7.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2217      +/-   ##
==========================================
+ Coverage   84.66%   92.04%   +7.37%     
==========================================
  Files         131      100      -31     
  Lines       15512    11236    -4276     
  Branches     2210     2210              
==========================================
- Hits        13134    10342    -2792     
+ Misses       2085      601    -1484     
  Partials      293      293              
Flag Coverage Δ
python 92.04% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/index/sbt/mhbt.rs
src/core/tests/storage.rs
src/core/src/ffi/storage.rs
src/core/src/index/bigsi.rs
src/core/src/encodings.rs
src/core/src/sketch/nodegraph.rs
src/core/tests/minhash.rs
src/core/src/ffi/signature.rs
src/core/src/index/revindex.rs
src/core/src/ffi/minhash.rs
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor

ctb commented Aug 17, 2022

I can't think of a specific situation where it will cause problems, and we don't do anything particularly tricky with stdout/stderr outside of the script runner (runtmp.sourmash(...)) so ... let's give it a try and see!!

@ctb ctb merged commit 775d879 into latest Aug 19, 2022
@ctb ctb deleted the test-stderr branch August 19, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants