Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourmash sig split should output .zip or .sig.gz files by default #2703

Closed
ctb opened this issue Aug 4, 2023 · 2 comments
Closed

sourmash sig split should output .zip or .sig.gz files by default #2703

ctb opened this issue Aug 4, 2023 · 2 comments
Labels
5.0 issues to address for a 5.0 release
Milestone
5.0

Comments

@ctb
Copy link
Contributor

ctb commented Aug 4, 2023

compression is good!

one backwards compatible approach would be to allow an extension to be specified for output files with -E/--extension.
@ctb ctb mentioned this issue Aug 12, 2023
Merged
@ctb ctb added the 5.0 issues to address for a 5.0 release label Aug 12, 2023
@ctb
Copy link
Contributor Author

ctb commented Aug 12, 2023

for sourmash v5, .sig.gz should be the default here.

ctb added a commit that referenced this issue Aug 12, 2023
@ctb
MRG: add support for -E/--extension to sig split (#2712)
f5c72fc 
This PR adds `-E/--extension` to `sourmash sig split`, so that you can
do (for example)
```
sourmash sig split -E .sig.gz database.zip
```
and get a bunch of `.sig.gz` files instead of a bunch of `.sig` files.

Addresses #2703
@ctb ctb mentioned this issue Aug 21, 2023
Open
@luizirber luizirber added this to the 5.0 milestone Dec 1, 2023
@ctb ctb mentioned this issue Mar 5, 2024
Open
@ctb
Copy link
Contributor Author

ctb commented Mar 5, 2024

closing in favor of #3068

@ctb ctb closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.0 issues to address for a 5.0 release
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@luizirber @ctb