Workaround for V8EXECUTOR_LIB NOTFOUND error in worklets CMakeLists.txt #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error Using v8 javascript engine was causing react-native-reanimated gradle build to fail: software-mansion#3570 Changing the `V8_SO_DIR` according to the recommendation from @reinismu fixes this: Kudo/react-native-v8#208 (comment)
tjzel
reviewed
Oct 22, 2024
packages/react-native-reanimated/android/src/main/cpp/worklets/CMakeLists.txt
Outdated
Show resolved
Hide resolved
…/CMakeLists.txt Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
tjzel
approved these changes
Dec 9, 2024
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
…xt (#6603) Using v8 javascript engine was causing react-native-reanimated gradle build to fail: #3570 Changing the `V8_SO_DIR` according to the recommendation from @reinismu fixes this: Kudo/react-native-v8#208 (comment) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fixes #3570 ## Test plan I'm not sure how the current CI is passing (#3570 (comment)), but that would be the way to test it. --------- Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
…xt (#6603) Using v8 javascript engine was causing react-native-reanimated gradle build to fail: #3570 Changing the `V8_SO_DIR` according to the recommendation from @reinismu fixes this: Kudo/react-native-v8#208 (comment) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fixes #3570 ## Test plan I'm not sure how the current CI is passing (#3570 (comment)), but that would be the way to test it. --------- Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
…xt (#6603) Using v8 javascript engine was causing react-native-reanimated gradle build to fail: #3570 Changing the `V8_SO_DIR` according to the recommendation from @reinismu fixes this: Kudo/react-native-v8#208 (comment) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fixes #3570 ## Test plan I'm not sure how the current CI is passing (#3570 (comment)), but that would be the way to test it. --------- Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
tomekzaw
pushed a commit
that referenced
this pull request
Jan 9, 2025
…xt (#6603) Using v8 javascript engine was causing react-native-reanimated gradle build to fail: #3570 Changing the `V8_SO_DIR` according to the recommendation from @reinismu fixes this: Kudo/react-native-v8#208 (comment) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fixes #3570 ## Test plan I'm not sure how the current CI is passing (#3570 (comment)), but that would be the way to test it. --------- Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
tomekzaw
added a commit
that referenced
this pull request
Jan 9, 2025
Merged
tomekzaw
added a commit
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using v8 javascript engine was causing react-native-reanimated gradle build to fail: #3570
Changing the
V8_SO_DIRaccording to the recommendation from @reinismu fixes this: Kudo/react-native-v8#208 (comment)Summary
Fixes #3570
Test plan
I'm not sure how the current CI is passing (#3570 (comment)), but that would be the way to test it.