Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of delfin redis container #968

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

amanr032
Copy link

What this PR does / why we need it:
Update name of delfin redis container because conflict with multicloud redis container

Which issue this PR fixes:
fixes

Test Report
image

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #968 (1850bb0) into master (c3080b5) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
+ Coverage   70.47%   70.48%   +0.01%     
==========================================
  Files         192      192              
  Lines       23235    23235              
  Branches     3570     3570              
==========================================
+ Hits        16375    16378       +3     
+ Misses       5735     5734       -1     
+ Partials     1125     1123       -2     
Impacted Files Coverage Δ
delfin/drivers/fake_storage/__init__.py 94.31% <0.00%> (+0.77%) ⬆️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sushanthakumar sushanthakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushanthakumar sushanthakumar merged commit 5901248 into sodafoundation:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants