fix: typing.Annotated
should be special-cased like typing.Literal
#193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #192
This is probably not a huge change, since we skipped unexpected nodes within annotations already, so it would mostly get rid of some false positives where a string within
Annotated
happened to match one of the imported symbols and thus being treated as a forward reference incorrectly.I still need to think about a solution for string annotations and whether or not we should visit the nodes we're currently skipping, maybe we should pass
self
intoAnnotationVisitor
so we can call thegeneric_visit
of the outer visitor?