feat: Add support for PEP646 syntax for unpacking TypeVarTuple
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sondrelg
reviewed
Jan 29, 2024
Comment on lines
+100
to
+101
| elif isinstance(node, ast.Starred) and isinstance(node.ctx, ast.Load): | ||
| self.visit(node.value) |
There was a problem hiding this comment.
This seems to suggest we'd support this syntax on all Python versions. Is that intentional?
There was a problem hiding this comment.
Yeah, it's the same rationale as with supporting | on earlier versions, invalid runtime uses will already be detected by type checkers and inside string annotations (i.e. also in regular annotations when you use from __future__ import annotations) it's legal to use future syntax.
In the case of starred expressions most(all?) uses in type expressions are actually invalid syntax prior to 3.11, so we have to worry even less. (Otherwise the use of this syntax could've been backported to earlier versions, since TypeVarTuple itself was backported via typing-extensions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182