-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take boolean attributes into account #49
Conversation
Thank you for the PR. Do you think you could add a test for this change? |
Looks good to me! I'll ping @paldepind to double check before releasing this. I saw he was active on this project recently, and I haven't touched this in a very long time. This is a bug fix but I'd do a major (6.0.0) since I believe this could break people's code, no? |
I've squashed the @paldepind Please feel free to merge this if you feel it's okay 🙏 |
@paldepind Pinging for your review (Sorry for interruption 🙇) |
@acstll It's been four months. Personally I'm also 👍 for making a major version bump. |
Hey, time flies. Sorry you had to wait this long. I think we can move forward. I'll merge and cut a major release this week. |
It's done @ryota-ka I hope everything's OK, haven't done this in a while! Thanks again for your patience. |
@acstll I also appreciate your review and releasing the new version! I'll enjoy it! |
Updated
modules/props.js
so that it will take boolean attributes into account.(
false
values for such attributes shouldn't be interpreted as"false"
)