Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supports null/undefined children #30

Merged
merged 1 commit into from
Sep 19, 2017
Merged

supports null/undefined children #30

merged 1 commit into from
Sep 19, 2017

Conversation

bouzuya
Copy link
Contributor

@bouzuya bouzuya commented Mar 5, 2017

@bouzuya bouzuya closed this Mar 5, 2017
@bouzuya
Copy link
Contributor Author

bouzuya commented Mar 5, 2017 •
edited
Loading

It might be a problem of my application or snabbdom.

... It seems better to fix it.

@bouzuya bouzuya reopened this Mar 5, 2017
@acstll
Copy link
Member

acstll commented Mar 10, 2017

I think this is good to merge (I would add a separate test unit instead of modifiyng an existing one, don't you think?)

@bouzuya bouzuya force-pushed the support-null-undefined branch from 21ab115 to e7b446d Compare March 12, 2017 02:02
@bouzuya
Copy link
Contributor Author

bouzuya commented Mar 12, 2017

ok?

@acstll
Copy link
Member

acstll commented Mar 12, 2017

Perfect, thank you.

@chenxeed
Copy link

Hi, when is this going to be merged? 😄

I need this since on passing an empty undefined string child, it return <div></div> instead of empty. Thanks!

@acstll
Copy link
Member

acstll commented Sep 18, 2017

I totally forgot about this, so sorry, it's been ages.

Will merge today, tomorrow the latest.

@chenxeed
Copy link

No worries, thanks @acstll ! 👍

@acstll acstll merged commit e7b446d into snabbdom:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bouzuya @acstll @chenxeed