Stateful NFV Packet Filtering #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,8 +59,8 @@ function create_config (input_dir, output_dir, hostname) | |||
| { vlan = vif_details.zone_vlan, | |||
| mac_address = port.mac_address, | |||
| port_id = port.id, | |||
| ingress_filter = filter(port, secbindings, secrules, 'ingress'), | |||
| egress_filter = filter(port, secbindings, secrules, 'egress'), | |||
| ingress_filter = filter(port, secbindings, secrules, 'ingress', vif_details.packetfilter), | |||
There was a problem hiding this comment.
The packetfilter setting should be in profile rather than vif_details.
profile contains configuration supplied by the user and vif_details contains information determined by the OpenStack code. (This is OpenStack Neutron semantics and not some funny invention of mine :-))
|
@N-Nikolaev How do these changes look to you? |
| ingress_filter = filter(port, secbindings, secrules, 'ingress'), | ||
| egress_filter = filter(port, secbindings, secrules, 'egress'), | ||
| ingress_filter = filter(port, secbindings, secrules, 'ingress', vif_details.packetfilter), | ||
| egress_filter = filter(port, secbindings, secrules, 'egress', vif_details.packetfilter), | ||
| gbps = vif_details.zone_gbps, |
There was a problem hiding this comment.
The packetfilter setting should be in profile rather than vif_details.
@lukego This line looks a bit fishy too now that I think about it. We never use the gbps field in nfvconfig... (and some sort of tx_police_gbps is missing too).
eugeneia
force-pushed
the
stateful-nfv-pf
branch
from
824188a to
13930f4
Compare
`profile.packetfilter' is "stateless".
rules are defined.
format (cce8b3).
`secbindings[port.id]' is a true value.
lukego
added a commit
that referenced
this pull request
Mar 20, 2015
Resolved simple conflict in neutron2snabb where lines were modified in the PR that were adjacent to a removed line on master. Conflicts: src/program/snabbnfv/neutron2snabb/neutron2snabb.lua
mwiget
pushed a commit
to mwiget/snabb
that referenced
this pull request
Sep 4, 2016
snabbvmx query to xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement NFV packet filtering as described in Neutron API Extensions/Stateless Packet Filtering.
E.g. if
vif_detailscontainspacketfilter="stateless"do stateless packet filtering. Otherwise do standard Neutron packet filtering.