Collected changes for June 2023 release: Davion #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eugeneia
commented
Jun 26, 2023
eugeneia
commented
- lib.ipv4.reassemble: fix missing argument in call to reassembly_error #1500
- apps.ipfix.maps: re-create map ctable if source file has changed #1501
- rss.metadata: store the metadate in the packet headroom area #1502
- ipfix: add acquire-cpu option to YANG schema #1503
- rss: fix missing local declaration in BPF filter construction #1504
- ipfix: add HTTPS templates to extract the TLS SNI #1506
Storing the metadata adjacent to the packet header is expected to improve L1 cache performance.
Add some unit test cases that exercise error paths.
If mk_map() is called via ipfix:reconfig() because the name of a map file has changed, the map ctable will still not be re-created due to its presence in the cache used by mk_map(). This commit uses the ctime of the file to detect whether the ctable needs to be re-created.
Reconfiguration of a ipfix app is currently implemented by re-creating all data structures. This causes disruption of flow collection even when it is not strictly necessary. As a first step towards a more graceful reconfiguration, this commit addresses the situation when the only change is in the set of mapping files of a template. In that case, only the mapping tables are reconstructed.
By defaut, exporter worker processes are pinned to a CPU from the configured cpu-pool. The new option allows this to be disabled on a per-exporter basis. It is intended to avoid depletion of the cpu-pool when many non-critical exporter processes are present.
Due to lack of a standard information element, this template re-uses a private element under the PEN of Progress/Flowmon (39499) to be compatible with their commercial Netflow collector. The templates parse the TLS handshake record of the client and look for the SNI extension in the Client Hello message for TLS 1.2 and later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.