-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lib.yang.list hash trie to store YANG lists #1490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New lib.yang.lists supports ordered lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hash trie implementation to be used for storing all YANG lists. The motivation for this is twofold:
ordered-by
statement for lists.lib.yang.list
tries are ordered and hence support this statement.Implementation wise this PR:
lib.yang.list
debug.traceback()
sometimes.Functionality wise this PR affects:
ordered-by user
, and leaves referring to other key leaves now use theleafref
type.lib.yang
andlib.ptree
: more types of configuration schemas should be able to be represented efficiently now.lib.yang.list
stores strings off-heap, so huge lists with string keys or members should be more ecomonical.Todo: